fix(local): make trial-build-patch.R detect non-throwing build failures #134

Merged
pat-s merged 1 commit from t3code/fix-trial-build-patch-falsegreen into main 2026-07-18 08:37:05 +00:00

2026-07-17

fix(local): make trial-build-patch.R detect non-throwing build failures
local/trial-build-patch.R -- the single-package acceptance gate the proposer
tells humans to run -- reported "Trial build OK" for a build that actually
failed (rstan's rstan.so failing to load with an undefined TBB symbol). Same
root cause as the registry gate before #130: build_binary_package() catches
failures internally and returns "error" rather than throwing, so a tryCatch that
only treats a thrown exception as failure false-greens.

Inspect the return value: a pass requires a non-empty result containing no
"error" sentinel. Mirrors the fix in trial-build-registry.R.
2026-07-17 14:51:20 +00:00