fix(local): make the trial-build gate detect non-throwing build failures #130

Merged

pat-s merged 1 commit from t3code/fix-gate-false-green into main

2026-07-16 08:24:03 +00:00

pat-s commented

2026-07-16 08:06:11 +00:00

Owner

Critical: the gate was false-green

The latest run printed 3/3 passed on alpine-324 while all three builds actually failed (their rstan dependency won't compile). A false-green gate would let broken registry entries merge — worse than no gate.

Root cause: bincraft::build_binary_package() catches build failures internally and returns "error" for the failed tag rather than throwing. The gate's tryCatch only treated a thrown exception as failure, so every non-throwing failure looked like a pass.

Fix: inspect the return value. A tag passes only if the flattened result is non-empty and contains no "error" sentinel; a thrown error still counts as failure. Verified the verdict against error/skipped/TRUE/list(success=TRUE)/NULL/mixed inputs.

With this, the current rstan-blocked entries will correctly show 0/3 (red) — which is the right answer until rstan builds.

## Critical: the gate was false-green The latest run printed **`3/3 passed on alpine-324`** while all three builds actually **failed** (their `rstan` dependency won't compile). A false-green gate would let broken registry entries merge — worse than no gate. Root cause: `bincraft::build_binary_package()` catches build failures internally and **returns `"error"`** for the failed tag rather than throwing. The gate's `tryCatch` only treated a *thrown* exception as failure, so every non-throwing failure looked like a pass. Fix: inspect the return value. A tag passes only if the flattened result is non-empty and contains no `"error"` sentinel; a thrown error still counts as failure. Verified the verdict against `error`/`skipped`/`TRUE`/`list(success=TRUE)`/`NULL`/mixed inputs. With this, the current rstan-blocked entries will correctly show **0/3 (red)** — which is the right answer until rstan builds.

pat-s added 1 commit

2026-07-16 08:06:11 +00:00

fix(local): make the trial-build gate detect non-throwing build failures 8a1e535d8b

The gate reported "3/3 passed" while all three builds actually failed (their
rstan dependency would not compile). Root cause: bincraft::build_binary_package()
catches build failures internally and RETURNS "error" for the failed tag instead
of throwing, so the gate's tryCatch never fired and every failed build looked
like a pass -- a false green that would let broken registry entries merge.

Inspect the return value: a tag is a pass only if the (flattened) result is
non-empty and contains no "error" sentinel; a thrown error still counts as
failure. Verified the verdict logic against error/skipped/TRUE/list/NULL/mixed.

pat-s merged commit 118a92889f into main

2026-07-16 08:24:03 +00:00

pat-s deleted branch t3code/fix-gate-false-green

2026-07-16 08:24:04 +00:00

pat-s referenced this pull request from a commit

2026-07-16 08:24:05 +00:00

fix(local): make the trial-build gate detect non-throwing build failures (#130)

pat-s referenced this pull request

2026-07-17 10:27:49 +00:00

fix(crow): make the trial-build gate no-op when the auto-patch branch is absent #132

pat-s referenced this pull request from a commit

2026-07-17 10:27:59 +00:00