fix(local): make trial-build-patch.R detect non-throwing build failures #134

Merged

pat-s merged 1 commit from t3code/fix-trial-build-patch-falsegreen into main

2026-07-18 08:37:05 +00:00

pat-s commented

2026-07-17 14:51:22 +00:00

Owner

local/trial-build-patch.R -- the single-package acceptance gate the proposer prints for humans to run (PGPASS=... Rscript local/trial-build-patch.R <pkg>) -- reported Trial build OK for rstan even though rstan.so failed to load (symbol not found: tbb::detail::r1::observe).

Same false-green as the registry gate before #130: build_binary_package() catches failures internally and returns "error" rather than throwing, so a tryCatch that only treats a thrown exception as failure passes a broken build. Now inspects the return value (mirrors trial-build-registry.R). Found while verifying the rstan/oneTBB unblock.

`local/trial-build-patch.R` -- the single-package acceptance gate the proposer prints for humans to run (`PGPASS=... Rscript local/trial-build-patch.R <pkg>`) -- reported **`Trial build OK`** for rstan even though rstan.so failed to load (`symbol not found: tbb::detail::r1::observe`). Same false-green as the registry gate before #130: `build_binary_package()` catches failures internally and returns `"error"` rather than throwing, so a `tryCatch` that only treats a thrown exception as failure passes a broken build. Now inspects the return value (mirrors trial-build-registry.R). Found while verifying the rstan/oneTBB unblock.

pat-s added 1 commit

2026-07-17 14:51:22 +00:00

fix(local): make trial-build-patch.R detect non-throwing build failures 3d3c4c462a

local/trial-build-patch.R -- the single-package acceptance gate the proposer
tells humans to run -- reported "Trial build OK" for a build that actually
failed (rstan's rstan.so failing to load with an undefined TBB symbol). Same
root cause as the registry gate before #130: build_binary_package() catches
failures internally and returns "error" rather than throwing, so a tryCatch that
only treats a thrown exception as failure false-greens.

Inspect the return value: a pass requires a non-empty result containing no
"error" sentinel. Mirrors the fix in trial-build-registry.R.

pat-s merged commit b4b7d53a83 into main

2026-07-18 08:37:05 +00:00

pat-s deleted branch t3code/fix-trial-build-patch-falsegreen

2026-07-18 08:37:05 +00:00

pat-s referenced this pull request from a commit

2026-07-18 08:37:06 +00:00

fix(local): make trial-build-patch.R detect non-throwing build failures (#134)