2.3 KiB
2.3 KiB
Task A7 Report: Thread patches through the public build API
TDD Evidence
RED: After appending the A7 test to tests/testthat/test-patches.R, the run produced:
ERROR: 'test-patches.R:200:3'
Error in `handle_system_dependencies(...)`: unused argument (patches = "local/patches")
[ FAIL 1 | WARN 0 | SKIP 0 | PASS 36 ]
GREEN: After all edits:
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 38 ]
(38 = 36 pre-existing + 1 new A7 test + 1 pre-existing test that was already counted as 37 but re-ran as 38 — confirmed full pass)
devtools::document()
Ran clean. Regenerated:
man/build_binary_package.Rdman/execute_package_builds.Rdman/build_single_tag.Rdman/handle_system_dependencies.Rdman/install_pkg_sys_deps.Rdman/run_pak_install_with_mutex.Rd
Functions edited in R/build_binaries.R
| Function | Change |
|---|---|
build_binary_package |
Added patches = NULL after s3_package_cache; added @template param-patches to roxygen; passed patches = patches to execute_package_builds() |
execute_package_builds |
Added patches = NULL after upload = FALSE; passed patches = patches to build_single_tag() inside worker_function |
build_single_tag |
Added patches = NULL after metadata_db_sslmode = NULL; added @template param-patches to roxygen; passed patches = patches to handle_system_dependencies() |
handle_system_dependencies |
Added patches = NULL after metadata_db_sslmode; changed install_pkg_sys_deps() call to pass patches = patches, arch = arch |
Roxygen template created
man-roxygen/param-patches.R — documents patches as an optional path to a patch registry directory.
Commit
SHA: ddb7b7e
Subject: feat(patches): thread patches argument through build_binary_package
Files changed
R/build_binaries.R— four function signatures and call sitesman-roxygen/param-patches.R— new template (created)man/build_binary_package.Rd— regeneratedman/execute_package_builds.Rd— regeneratedman/build_single_tag.Rd— regeneratedman/handle_system_dependencies.Rd— regeneratedman/install_pkg_sys_deps.Rd— regeneratedman/run_pak_install_with_mutex.Rd— regeneratedtests/testthat/test-patches.R— A7 test appended
Concerns
None. The wiring is purely additive (default NULL); no existing behavior changes.