fix(abi): do not error on the nothing-to-repair path #208

Merged

pat-s merged 1 commit from fix/nothing-to-repair-must-not-error into main

2026-09-09 10:55:15 +00:00

pat-s commented

2026-09-09 10:46:03 +00:00

Owner

Why

Pipeline 12480 shows this for slots with nothing to do:

Error in sprintf("%s/%s: %d objects recorded, none unsafe. Nothing to repair.",  :

RPostgres returns count(*) as integer64, and %d rejects it. So a slot in the best possible state — verdicts recorded, nothing unsafe — failed its pipeline step, while slots with real work to do succeeded. Exactly the wrong signal.

What changed

Formats the count as a string. One line, plus a comment recording why %d is wrong here.

## Why Pipeline 12480 shows this for slots with nothing to do: ``` Error in sprintf("%s/%s: %d objects recorded, none unsafe. Nothing to repair.", : ``` `RPostgres` returns `count(*)` as `integer64`, and `%d` rejects it. So a slot in the **best possible state** — verdicts recorded, nothing unsafe — failed its pipeline step, while slots with real work to do succeeded. Exactly the wrong signal. ## What changed Formats the count as a string. One line, plus a comment recording why `%d` is wrong here.

pat-s added 1 commit

2026-09-09 10:46:03 +00:00

fix(abi): do not error on the nothing-to-repair path fcbc4e8e92

A slot with verdicts recorded but nothing unsafe died on its own success
message:

  Error in sprintf("%s/%s: %d objects recorded, none unsafe. Nothing to repair.", ...)

RPostgres returns count(*) as integer64, which %d rejects. The pipeline step
then failed for a slot that was in the best possible state, which is the wrong
signal entirely.

pat-s merged commit 4342fa773a into main

2026-09-09 10:55:15 +00:00

pat-s deleted branch fix/nothing-to-repair-must-not-error

2026-09-09 10:55:16 +00:00

pat-s referenced this pull request from a commit

2026-09-09 10:55:17 +00:00

fix(abi): do not error on the nothing-to-repair path (#208)