fix(abi): do not error on the nothing-to-repair path #208

Merged
pat-s merged 1 commit from fix/nothing-to-repair-must-not-error into main 2026-09-09 10:55:15 +00:00
Showing only changes of commit fcbc4e8e92 - Show all commits

fix(abi): do not error on the nothing-to-repair path

A slot with verdicts recorded but nothing unsafe died on its own success
message:

  Error in sprintf("%s/%s: %d objects recorded, none unsafe. Nothing to repair.", ...)

RPostgres returns count(*) as integer64, which %d rejects. The pipeline step
then failed for a slot that was in the best possible state, which is the wrong
signal entirely.
Patrick Schratz 2026-09-09 10:45:59 +00:00
No known key found for this signature in database
GPG key ID: 62050D5BC68AB6DC

View file

@ -141,11 +141,13 @@ if (nrow(rows) == 0L) {
call. = FALSE
)
}
# `count(*)` arrives as a double (or integer64), and `%d` rejects both, so the
# nothing-to-do path used to die on its own success message.
message(sprintf(
"%s/%s: %d objects recorded, none unsafe. Nothing to repair.",
"%s/%s: %s objects recorded, none unsafe. Nothing to repair.",
arch,
codename,
total
format(as.numeric(total), scientific = FALSE)
))
quit(status = 0)
}