fix(crow): make the trial-build gate no-op when the auto-patch branch is absent #132

Merged
pat-s merged 1 commit from t3code/gate-resilient-missing-branch into main 2026-07-17 10:27:59 +00:00
Owner

Problem

The trial pipeline errored:

git clone -q --branch auto/registry-patch-proposals ...
fatal: Remote branch auto/registry-patch-proposals not found in upstream origin

I deleted the stale auto/registry-patch-proposals branch during cleanup, and — now that cascade detection (#128) makes the proposer correctly find no candidates — the proposer exits before ever recreating it. So the branch is legitimately absent, and the gate's hard git clone --branch fails.

Fix

"Branch absent" = "no pending auto-patch proposals" = nothing to verify, which should be a clean no-op, not a failure. Clone main, then fetch + checkout the patch branch only if it exists; otherwise log and exit 0. A present branch is verified exactly as before (checkout its tip, diff registry vs main).

This also means the gate now runs main's trial-build-registry.R (with the #130 fix) rather than a possibly-stale copy on the branch.

## Problem The trial pipeline errored: ``` git clone -q --branch auto/registry-patch-proposals ... fatal: Remote branch auto/registry-patch-proposals not found in upstream origin ``` I deleted the stale `auto/registry-patch-proposals` branch during cleanup, and — now that cascade detection (#128) makes the proposer correctly find **no candidates** — the proposer exits before ever recreating it. So the branch is legitimately absent, and the gate's hard `git clone --branch` fails. ## Fix "Branch absent" = "no pending auto-patch proposals" = **nothing to verify**, which should be a clean no-op, not a failure. Clone `main`, then fetch + checkout the patch branch only if it exists; otherwise log and `exit 0`. A present branch is verified exactly as before (checkout its tip, diff registry vs `main`). This also means the gate now runs `main`'s `trial-build-registry.R` (with the #130 fix) rather than a possibly-stale copy on the branch.
The gate hard-cloned `--branch ${patch_branch}`, so when that branch does not
exist it failed with "Remote branch ... not found in upstream origin". With
cascade detection live the proposer often has no candidates and never
(re)creates the branch, so "branch absent" is the normal "nothing to verify"
state, not an error.

Clone main, then fetch+checkout the patch branch only if it exists; otherwise
log and exit 0. A present branch is verified as before.
pat-s merged commit 13fcad6dc4 into main 2026-07-17 10:27:59 +00:00
pat-s deleted branch t3code/gate-resilient-missing-branch 2026-07-17 10:27:59 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
devxy/build-cran-binaries!132
No description provided.