build-cran-binaries/docker
Repository files (latest commit first)
Filename Latest commit message Latest commit date
pat-s b744ae1bb1 fix: build-one image bincraft v4.4.0 + ship patch registry (#104)
## Summary

Fixes the **targeted rebuild** path (`just rebuild` → `docker/build-one.Dockerfile`) so it actually applies patches.

Two problems, both of which would make `build-one.R`'s `patches = "local/patches"` a silent no-op or a hard error:

1. **Stale bincraft pin.** The Dockerfile pinned bincraft `v4.2.1`, which predates the `patches` argument — so `build_binary_package(patches = ...)` would fail with `unused argument`. Bumped to **v4.4.0** to match the `.crow` workflows.
2. **Registry not shipped into the image.** Only `build-one.R` was copied in; `local/patches/registry.json` was absent, so `patches = "local/patches"` resolved to a nonexistent `/work/local/patches` and silently applied nothing. Added `COPY patches /work/local/patches` (build context is `local/`, CWD is `/work`).

## Why

This is the path used to verify the patching end-to-end, e.g.:

```bash
just rebuild alpine 3.23 amd64 rts2 1.0.3
```

rts2 depends on RcppParallel; with this fix the container installs bincraft v4.4.0, ships the registry, and the patched RcppParallel binary (`RCPP_PARALLEL_USE_TBB=0`) is served to pak during dependency install. Expect `Applying patch to RcppParallel …` in the log, RcppParallel installed as a binary (no recompile), then rts2 building and uploading.

Reviewed-on: #104
2026-06-30 12:15:39 +00:00
..
reprex chore: add alpine regex 2024-11-01 19:32:07 +01:00
build-one.Dockerfile fix: build-one image bincraft v4.4.0 + ship patch registry (#104) 2026-06-30 12:15:39 +00:00
Containerfile-shiny-app refactor: bincraftR -> bincraft 2025-06-08 15:39:54 +02:00