Some checks failed
ci/crow/manual/repair-built-stamp/2 Pipeline is pending
ci/crow/manual/trial-build-registry/2 Pipeline is pending
ci/crow/manual/trial-build-registry/4 Pipeline is pending
ci/crow/manual/trial-build-registry/6 Pipeline is pending
ci/crow/manual/trial-build-registry/8 Pipeline is pending
ci/crow/manual/trial-build-registry/10 Pipeline is pending
ci/crow/manual/trial-build-registry/12 Pipeline is pending
ci/crow/manual/trial-build-registry/14 Pipeline is pending
ci/crow/manual/trial-build-registry/16 Pipeline is pending
ci/crow/manual/trial-build-registry/18 Pipeline is pending
ci/crow/manual/weekly-audit-missing/2 Pipeline is pending
ci/crow/manual/weekly-audit-missing/4 Pipeline is pending
ci/crow/manual/weekly-audit-missing/6 Pipeline is pending
ci/crow/manual/weekly-audit-missing/8 Pipeline is pending
ci/crow/manual/weekly-audit-missing/10 Pipeline is pending
ci/crow/manual/weekly-audit-missing/12 Pipeline is pending
ci/crow/manual/weekly-audit-missing/14 Pipeline is pending
ci/crow/manual/weekly-audit-missing/16 Pipeline is pending
ci/crow/manual/weekly-audit-missing/18 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/2 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/4 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/5 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/6 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/7 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/8 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/9 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/10 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/11 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/12 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/13 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/14 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/15 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/16 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/17 Pipeline is pending
ci/crow/manual/weekly-rebuild-missing/18 Pipeline is pending
ci/crow/manual/process-updates/9 Pipeline was successful
ci/crow/manual/process-updates/7 Pipeline was successful
ci/crow/manual/auto-apply-patches Pipeline was successful
ci/crow/manual/trial-build-registry/1 Pipeline was successful
ci/crow/manual/trial-build-registry/3 Pipeline was successful
ci/crow/manual/trial-build-registry/5 Pipeline was successful
ci/crow/manual/trial-build-registry/7 Pipeline was successful
ci/crow/manual/trial-build-registry/9 Pipeline was successful
ci/crow/manual/trial-build-registry/11 Pipeline was successful
ci/crow/manual/trial-build-registry/13 Pipeline was successful
ci/crow/manual/trial-build-registry/15 Pipeline was successful
ci/crow/manual/trial-build-registry/17 Pipeline was successful
ci/crow/manual/build-all-versions-install-deps/1 Pipeline was successful
ci/crow/manual/weekly-audit-missing/1 Pipeline was successful
ci/crow/manual/process-updates/3 Pipeline was successful
ci/crow/manual/process-updates/2 Pipeline was successful
ci/crow/manual/process-updates/4 Pipeline was successful
ci/crow/manual/process-updates/8 Pipeline was successful
ci/crow/manual/weekly-audit-missing/3 Pipeline was successful
ci/crow/manual/process-updates/13 Pipeline was successful
ci/crow/manual/weekly-audit-missing/7 Pipeline was successful
ci/crow/manual/weekly-audit-missing/9 Pipeline was successful
ci/crow/manual/weekly-audit-missing/11 Pipeline was successful
ci/crow/manual/weekly-audit-missing/15 Pipeline was successful
ci/crow/manual/weekly-audit-missing/5 Pipeline was successful
ci/crow/manual/weekly-patch-proposals Pipeline was successful
ci/crow/manual/process-updates/10 Pipeline was successful
ci/crow/manual/weekly-audit-missing/13 Pipeline was successful
ci/crow/manual/weekly-audit-missing/17 Pipeline was successful
ci/crow/manual/process-updates/14 Pipeline was successful
ci/crow/manual/build-all-versions/4 Pipeline was canceled
ci/crow/manual/process-updates/12 Pipeline was canceled
ci/crow/manual/build-all-versions/2 Pipeline was canceled
ci/crow/manual/build-all-versions/1 Pipeline was canceled
ci/crow/manual/weekly-rebuild-missing/1 Pipeline was canceled
ci/crow/manual/process-updates/6 Pipeline was canceled
ci/crow/manual/process-updates/18 Pipeline was canceled
ci/crow/manual/process-updates/16 Pipeline was canceled
ci/crow/manual/process-updates/17 Pipeline was canceled
ci/crow/manual/process-updates/11 Pipeline was canceled
ci/crow/manual/process-updates/1 Pipeline was canceled
ci/crow/manual/weekly-rebuild-missing/3 Pipeline was canceled
ci/crow/manual/process-updates/5 Pipeline was canceled
ci/crow/manual/process-updates/15 Pipeline was canceled
ci/crow/manual/build-all-versions/3 Pipeline was canceled
ci/crow/manual/build-all-versions-install-deps/2 Pipeline was successful
ci/crow/manual/build-all-versions/6 Pipeline was successful
ci/crow/manual/build-all-versions/5 Pipeline failed
ci/crow/manual/build-all-versions/7 Pipeline failed
ci/crow/manual/build-all-versions/8 Pipeline failed
ci/crow/cron/process-updates/17 Pipeline was successful
ci/crow/cron/process-updates/11 Pipeline was successful
ci/crow/cron/process-updates/1 Pipeline was successful
ci/crow/cron/process-updates/18 Pipeline was successful
ci/crow/cron/process-updates/16 Pipeline was successful
ci/crow/cron/process-updates/2 Pipeline was successful
ci/crow/cron/process-updates/6 Pipeline was successful
ci/crow/cron/process-updates/7 Pipeline was successful
ci/crow/cron/process-updates/12 Pipeline was successful
ci/crow/cron/process-updates/5 Pipeline was successful
## Problem
`repair-built-stamp.yaml` gated on `target_arch`:
```yaml
when:
- event: manual
evaluate: 'target_arch == "${ARCH}"'
```
That is the same variable `build-all-versions.yaml` and `build-all-versions-install-deps.yaml` gate on. A manual run passing `target_arch=arm64` to reach the repair therefore matched all three, so triggering a dry-run repair also queued a full arm64 rebuild.
I hit this triggering the alpine 3.22 dry run (pipeline 10706), which I killed. `crow pipeline ps` renders empty states on this version, so I could not confirm from the CLI whether the rebuild workflows started before the kill or only sat queued behind the running cron jobs; no output was attributable to them.
## Change
Gate on `repair_built_stamp` instead. Every other pipeline here already gates on a variable named after itself (`process_cran_updates`, `weekly_audit_missing`, `weekly_rebuild_missing`), and `target_arch` was the odd one out being shared by two.
The header now records the collision and the exact invocation, so the next pipeline added here does not repeat it.
## Verification
`crow lint` passes; `prek` clean.
Grep of every trigger condition in `.crow/` confirms `repair_built_stamp` is unique and that no other pipeline gates on `OS`, `OS_VERSION`, `R_VERSION` or `dry_run` alone:
```
archive-missed-packages.yaml: task == "archive-missed-packages"
build-all-versions.yaml: target_arch == "${ARCH}"
build-all-versions-install-deps.yaml: target_arch == "${ARCH}"
weekly-audit-missing.yaml: weekly_audit_missing == ...
repair-built-stamp.yaml: repair_built_stamp == "${ARCH}"
process-updates.yaml: process_cran_updates == ...
weekly-rebuild-missing.yaml: weekly_rebuild_missing == ...
```
## Note for whoever runs it
`crow pipeline create` against this instance returned HTTP 504 while still creating the pipeline. Retrying on that error duplicates the run: I created four before noticing. Verify with `pipeline ls` rather than trusting the exit status.
Reviewed-on: #151
106 lines
3.1 KiB
YAML
106 lines
3.1 KiB
YAML
### Manual repair of a slot whose PACKAGES index advertises a broken `Built`
|
|
### stamp (e.g. `Built: R 4.5.0; NA; ...`).
|
|
#
|
|
# uvr matches the stamp's platform triple plus R minor to decide binary vs
|
|
# source, so an unusable triple turns a whole slot source-only. See
|
|
# local/repair-built-stamp.R for why this patches PACKAGES.db in place instead
|
|
# of forcing a full reparse.
|
|
#
|
|
# Run with `dry_run: true` first: it reports how many entries are broken per
|
|
# slot and changes nothing. Pick the R version the slot should advertise, which
|
|
# is the R_VERSION its entry in .crow/process-updates.yaml uses.
|
|
#
|
|
# The gate variable is `repair_built_stamp`, not `target_arch`: `target_arch` is
|
|
# what build-all-versions and build-all-versions-install-deps gate on, so a
|
|
# manual run passing it would start a full rebuild alongside this repair. Every
|
|
# pipeline here gates on a variable named after itself for exactly that reason.
|
|
#
|
|
# crow pipeline create --branch main \
|
|
# --var repair_built_stamp=arm64 --var OS=alpine --var OS_VERSION=3.22 \
|
|
# --var R_VERSION=4.5.3 --var dry_run=true devxy/build-cran-binaries
|
|
variables:
|
|
repair_built_stamp:
|
|
description: 'Architecture of the slot to repair. Also gates this pipeline.'
|
|
options:
|
|
- amd64
|
|
- arm64
|
|
default: arm64
|
|
OS:
|
|
description: 'Base OS image name.'
|
|
options:
|
|
- alpine
|
|
- redhat
|
|
- ubuntu
|
|
default: alpine
|
|
OS_VERSION:
|
|
description: 'OS image tag. Must match OS (alpine: 3.22/3.23/3.24; redhat: 8/9/10; ubuntu: jammy/noble/resolute).'
|
|
options:
|
|
- '3.22'
|
|
- '3.23'
|
|
- '3.24'
|
|
- '8'
|
|
- '9'
|
|
- '10'
|
|
- 'jammy'
|
|
- 'noble'
|
|
- 'resolute'
|
|
default: '3.22'
|
|
R_VERSION:
|
|
description: 'R version whose stamp the slot should advertise.'
|
|
options:
|
|
- 4.5.3
|
|
- 4.4.3
|
|
default: 4.5.3
|
|
dry_run:
|
|
description: 'Report what would change without writing anything.'
|
|
options:
|
|
- 'true'
|
|
- 'false'
|
|
default: 'true'
|
|
|
|
when:
|
|
- event: manual
|
|
evaluate: 'repair_built_stamp == "${ARCH}"'
|
|
|
|
skip_clone: true
|
|
|
|
labels:
|
|
platform: linux/${ARCH}
|
|
group: rpkgs-${ARCH}
|
|
|
|
matrix:
|
|
include:
|
|
- ARCH: amd64
|
|
- ARCH: arm64
|
|
|
|
steps:
|
|
- name: 'Repair Built stamp'
|
|
image: 'reg.devxy.io/rpkgs/build-env-${OS}:${OS_VERSION}'
|
|
pull: true
|
|
environment:
|
|
B2_S3_ACCESS_KEY:
|
|
from_secret: B2_S3_ACCESS_KEY
|
|
B2_S3_SECRET_KEY:
|
|
from_secret: B2_S3_SECRET_KEY
|
|
REPO_RO_TOKEN:
|
|
from_secret: REPO_RO_TOKEN
|
|
GIT_USER: pat-s
|
|
commands:
|
|
- git clone -q https://pat-s:$$REPO_RO_TOKEN@git.devxy.io/devxy/build-cran-binaries.git .
|
|
- /opt/R/$R_VERSION/bin/Rscript local/install-bincraft.R
|
|
- /opt/R/$R_VERSION/bin/R -q -e 'packageVersion("bincraft")'
|
|
- |
|
|
if [ "$dry_run" = "false" ]; then
|
|
/opt/R/$R_VERSION/bin/Rscript local/repair-built-stamp.R "$ARCH" --apply
|
|
else
|
|
/opt/R/$R_VERSION/bin/Rscript local/repair-built-stamp.R "$ARCH"
|
|
fi
|
|
backend_options:
|
|
docker:
|
|
resources:
|
|
requests:
|
|
memory: 2Gi
|
|
cpu: 1000m
|
|
limits:
|
|
memory: 8Gi
|
|
cpu: 2000m
|