devxy/build-cran-binaries
Watch
1
0
Fork
You've already forked build-cran-binaries
 0
Code Issues 10 Pull requests Releases Activity

fix: recompute package snapshot when missing from cache #95

Merged
pat-s merged 1 commit from fix/recompute-missing-package-snapshot into main 2026-06-17 17:49:05 +00:00
Conversation 0 Commits 1 Files changed 1 +25
1 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 26ac988717 - Show all commits

fix: recompute package snapshot when missing from cache

Prev Next 
The install-deps step precomputes pkgs_to_build.rds, r_minor_sensitive_pkgs.rds
and s3_cache.rds into /mnt/cache, but that cache volume is per-agent.
A build job scheduled on a fresh agent (or racing install-deps) finds the
snapshot absent and fails at readRDS.

Guard the reads in build-all.R: when any snapshot file is missing, source
packages-to-build.R and save the derived files (atomic temp+rename so a
concurrent job never reads a half-written rds). The first job on an agent
repopulates the shared cache for subsequent jobs; jobs that also miss redo
the work.
Patrick Schratz 2026-06-17 19:47:28 +02:00
commit 26ac988717
Signed by: pat-s
GPG key ID: 3C6318841EF78925

25
local/build-all.R
View file

@ -15,6 +15,31 @@ library(bincraft, quietly = TRUE)
library(future) library(future)
plan("sequential") plan("sequential")
# The install-deps step precomputes the package snapshot into /mnt/cache, but
# that volume is per-agent: a job landing on a fresh agent (or racing
# install-deps) finds it empty. Recompute the snapshot here when any part is
# missing, so the first job on an agent repopulates the cache for the jobs that
# follow; concurrent jobs that also miss simply redo the work. Write via a
# temp file + atomic rename so a concurrent reader never sees a half-written rds.
package_cache_files <- c(
"/mnt/cache/packages/pkgs_to_build.rds",
"/mnt/cache/packages/r_minor_sensitive_pkgs.rds",
"/mnt/cache/packages/s3_cache.rds"
)
if (!all(file.exists(package_cache_files))) {
message("Package snapshot missing from cache; recomputing via packages-to-build.R")
dir.create("/mnt/cache/packages", showWarnings = FALSE, recursive = TRUE)
save_rds_atomic <- function(obj, path) {
tmp <- paste0(path, ".tmp.", Sys.getpid())
saveRDS(obj, tmp)
file.rename(tmp, path)
}
source(file.path("local", "packages-to-build.R"))
save_rds_atomic(pkgs, "/mnt/cache/packages/pkgs_to_build.rds")
save_rds_atomic(pkgs[r_minor_sensitive == TRUE], "/mnt/cache/packages/r_minor_sensitive_pkgs.rds")
message("Package snapshot recomputed.")
}
pkgs <- if (sensitive_only) { pkgs <- if (sensitive_only) {
readRDS("/mnt/cache/packages/r_minor_sensitive_pkgs.rds") readRDS("/mnt/cache/packages/r_minor_sensitive_pkgs.rds")
} else { } else {