refactor: single source of truth for excluded packages #79

Merged

pat-s merged 1 commit from pr/single-excluded-packages-source into main

2026-06-08 08:30:20 +00:00

pat-s commented

2026-05-28 13:51:18 +00:00

Owner

Summary

local/build-all.R had a 75-name hardcoded exclude <- c(...) vector that had drifted from local/excluded-packages.json — RcmdrPlugin.ROC was in the R vector but missing from the JSON.

.crow/weekly-rebuild-missing-*.yaml already reads the JSON via jsonlite::fromJSON(...)[["package"]]. This brings build-all.R in line with that pattern.

Changes:

local/excluded-packages.json: add the missing RcmdrPlugin.ROC entry (reason "hang", matching siblings).
local/build-all.R: replace the 16-line hardcoded vector with one jsonlite::fromJSON(...) call.
.crow/build-all-versions-install-deps-{amd,arm}64.yaml: add jsonlite to the install-deps pak::pak() list so it's available in /mnt/cache/R-pkgs for the build step.
.crow/build-all-versions-arm64.yaml: drop the dead base64-encoded SKIP_PKGS docs comment that nobody was passing as a --var anyway; replace with a one-line pointer to the JSON.

## Summary `local/build-all.R` had a 75-name hardcoded `exclude <- c(...)` vector that had drifted from `local/excluded-packages.json` — `RcmdrPlugin.ROC` was in the R vector but missing from the JSON. `.crow/weekly-rebuild-missing-*.yaml` already reads the JSON via `jsonlite::fromJSON(...)[["package"]]`. This brings `build-all.R` in line with that pattern. Changes: - **`local/excluded-packages.json`**: add the missing `RcmdrPlugin.ROC` entry (reason `"hang"`, matching siblings). - **`local/build-all.R`**: replace the 16-line hardcoded vector with one `jsonlite::fromJSON(...)` call. - **`.crow/build-all-versions-install-deps-{amd,arm}64.yaml`**: add `jsonlite` to the install-deps `pak::pak()` list so it's available in `/mnt/cache/R-pkgs` for the build step. - **`.crow/build-all-versions-arm64.yaml`**: drop the dead base64-encoded `SKIP_PKGS` docs comment that nobody was passing as a `--var` anyway; replace with a one-line pointer to the JSON.

pat-s added 1 commit

2026-05-28 13:51:18 +00:00

refactor: single source of truth for excluded packages 98a661faef

local/build-all.R had a 75-name hardcoded vector that drifted from
local/excluded-packages.json (RcmdrPlugin.ROC was in the R vector
but missing from the JSON). weekly-rebuild-missing-* already reads
the JSON, so this aligns build-all.R with that pattern.

- Add the missing RcmdrPlugin.ROC entry to excluded-packages.json
- Replace the hardcoded vector in build-all.R with
  jsonlite::fromJSON("local/excluded-packages.json")[["package"]]
- Pull jsonlite into the install-deps step so it's available in
  /mnt/cache/R-pkgs for the build step
- Drop the dead base64 SKIP_PKGS docs comment from
  build-all-versions-arm64.yaml; point to the JSON instead

pat-s merged commit 53da568749 into main

2026-06-08 08:30:20 +00:00

pat-s referenced this pull request from a commit

2026-06-08 08:30:20 +00:00

refactor: single source of truth for excluded packages (#79)

pat-s deleted branch pr/single-excluded-packages-source

2026-06-08 08:30:20 +00:00