fix(build): scope the errored-package filter to the snapshot's R minor #194

Merged

pat-s merged 1 commit from fix/scope-errored-packages-by-minor into main

2026-09-03 13:37:05 +00:00

pat-s commented

2026-09-03 10:10:21 +00:00

Owner

Why

After #192 and #193 the builds stopped recompiling what they already had, but every slot still showed a per-minor gap that a successful run did not close:

arm64/resolute   3302   amd64/resolute  1783   amd64/alpine324 1163
arm64/alpine324  1104   arm64/rhel8      572   amd64/rhel8      532
amd64/rhel10      453   arm64/rhel10     176   (others <= 13)

amd64/alpine324 had just completed successfully, yet 655 ABI-risky packages were still absent from its 4.6 index. Sampling 25 of them against that run's log:

attempted: 0   errored: 0   uploaded: 0   never attempted: 25

They were filtered out before the build loop. The candidate list drops every package with an error row for this platform/arch:

SELECT name, tag FROM single_builds
WHERE error_occurred = TRUE and platform='%s' and arch='%s'

There is no r_version in that predicate, and the row is keyed by (name, tag, platform, arch) only. So a single failure under one minor cancels the package's builds under every other minor, permanently.

The index data matches that shape rather than a build-failure shape: of the 508 ABI-risky packages missing from alpine324's 4.4 index, 505 are also missing from 4.6 - a 99% overlap. Genuine per-minor failures would not correlate that way (only 3 were 4.4-specific).

What changed

Adds the substring(r_version from '^[0-9]+[.][0-9]+') = '<minor>' scoping already used by check_package_error() (#119) and the per-minor error query (#189).

Errors specific to another minor are still respected downstream: filter_packages_with_errors() runs per pass with that pass's own r_version, so a package that genuinely fails under 4.6 is still skipped there.

Verification

Rendered query:

SELECT name, tag FROM single_builds WHERE error_occurred = TRUE
  and platform='alpine-324' and arch='amd64'
  and substring(r_version from '^[0-9]+[.][0-9]+') = '4.5'

Routing itself is unaffected and remains green: verify-r-minor-routing.sh reports 232 passed / 0 failed across all 16 slots, and --live reported 328 passed / 0 failed.

## Why After #192 and #193 the builds stopped recompiling what they already had, but every slot still showed a per-minor gap that a successful run did not close: ``` arm64/resolute 3302 amd64/resolute 1783 amd64/alpine324 1163 arm64/alpine324 1104 arm64/rhel8 572 amd64/rhel8 532 amd64/rhel10 453 arm64/rhel10 176 (others <= 13) ``` amd64/alpine324 had just completed successfully, yet 655 ABI-risky packages were still absent from its 4.6 index. Sampling 25 of them against that run's log: ``` attempted: 0 errored: 0 uploaded: 0 never attempted: 25 ``` They were filtered out before the build loop. The candidate list drops every package with an error row for this platform/arch: ```sql SELECT name, tag FROM single_builds WHERE error_occurred = TRUE and platform='%s' and arch='%s' ``` There is no `r_version` in that predicate, and the row is keyed by `(name, tag, platform, arch)` only. So a single failure under one minor cancels the package's builds under every other minor, permanently. The index data matches that shape rather than a build-failure shape: of the 508 ABI-risky packages missing from alpine324's 4.4 index, **505 are also missing from 4.6** - a 99% overlap. Genuine per-minor failures would not correlate that way (only 3 were 4.4-specific). ## What changed Adds the `substring(r_version from '^[0-9]+[.][0-9]+') = '<minor>'` scoping already used by `check_package_error()` (#119) and the per-minor error query (#189). Errors specific to another minor are still respected downstream: `filter_packages_with_errors()` runs per pass with that pass's own `r_version`, so a package that genuinely fails under 4.6 is still skipped there. ## Verification Rendered query: ```sql SELECT name, tag FROM single_builds WHERE error_occurred = TRUE and platform='alpine-324' and arch='amd64' and substring(r_version from '^[0-9]+[.][0-9]+') = '4.5' ``` Routing itself is unaffected and remains green: `verify-r-minor-routing.sh` reports 232 passed / 0 failed across all 16 slots, and `--live` reported 328 passed / 0 failed.

pat-s added 1 commit

2026-09-03 10:10:21 +00:00

fix(build): scope the errored-package filter to the snapshot's R minor 699d299185

The candidate list removed every package with an error row for this
platform/arch, regardless of the R version that produced it. The row is keyed
by (name, tag, platform, arch) only, so one failure under 4.6 also cancelled
that package's 4.4 and 4.5 builds, permanently and silently.

This is what the residual per-minor gaps were. On amd64/alpine324, 505 of the
508 ABI-risky packages missing from the 4.4 index were also missing from 4.6, a
99% overlap that per-minor build failures would not produce, and none of them
were attempted by the run that had just succeeded.

Errors specific to another minor are still respected: bincraft's
filter_packages_with_errors() runs per pass with that pass's own r_version.

This change will:

- add the same substring(r_version ...) scoping used by #119 and #189

pat-s merged commit a650f1d18a into main

2026-09-03 13:37:05 +00:00

pat-s deleted branch fix/scope-errored-packages-by-minor

2026-09-03 13:37:05 +00:00

pat-s referenced this pull request from a commit

2026-09-03 13:37:06 +00:00

fix(build): scope the errored-package filter to the snapshot's R minor (#194)