devxy/build-cran-binaries
Watch
1
0
Fork
You've already forked build-cran-binaries
 0
Code Issues 12 Pull requests Releases Activity

fix(abi): do not error on the nothing-to-repair path

Browse source 
A slot with verdicts recorded but nothing unsafe died on its own success
message:

  Error in sprintf("%s/%s: %d objects recorded, none unsafe. Nothing to repair.", ...)

RPostgres returns count(*) as integer64, which %d rejects. The pipeline step
then failed for a slot that was in the best possible state, which is the wrong
signal entirely.
This commit is contained in:
Patrick Schratz 2026-09-09 10:45:59 +00:00
commit fcbc4e8e92
No known key found for this signature in database
GPG key ID: 62050D5BC68AB6DC
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
local/list-unsafe-flat-objects.R
View file

@ -141,11 +141,13 @@ if (nrow(rows) == 0L) {
call. = FALSE call. = FALSE
) )
} }
# `count(*)` arrives as a double (or integer64), and `%d` rejects both, so the
# nothing-to-do path used to die on its own success message.
message(sprintf( message(sprintf(
"%s/%s: %d objects recorded, none unsafe. Nothing to repair.", "%s/%s: %s objects recorded, none unsafe. Nothing to repair.",
arch, arch,
codename, codename,
total format(as.numeric(total), scientific = FALSE)
)) ))
quit(status = 0) quit(status = 0)
} }