fix(patches): validator portability, clearer docs, broader hook trigger
This commit is contained in:
parent
a826a27246
commit
f3f3bfa20d
1 changed files with 2428 additions and 8 deletions
40
.superpowers/handoff/task-B4-brief.md
Normal file
40
.superpowers/handoff/task-B4-brief.md
Normal file
|
|
@ -0,0 +1,40 @@
|
|||
### Task B4: Pass `patches` through the build entry points
|
||||
|
||||
**Files:**
|
||||
- Modify: `local/build-one.R:99-119` (the `build_binary_package` call)
|
||||
- Modify: `local/build-all.R:125-145` (the `build_binary_package` call)
|
||||
|
||||
**Interfaces:**
|
||||
- Consumes: the new bincraft `patches` argument (Phase A) and `local/patches/`.
|
||||
- Produces: both entry points pass `patches = "local/patches"`.
|
||||
|
||||
- [ ] **Step 1: Edit `local/build-one.R`**
|
||||
|
||||
In the `bincraft::build_binary_package(` call, add as a new argument (e.g. after `archive = TRUE,`):
|
||||
|
||||
```r
|
||||
patches = "local/patches",
|
||||
```
|
||||
|
||||
- [ ] **Step 2: Edit `local/build-all.R`**
|
||||
|
||||
In the `bincraft::build_binary_package(` call, add:
|
||||
|
||||
```r
|
||||
patches = "local/patches",
|
||||
```
|
||||
|
||||
- [ ] **Step 3: Verify the scripts still parse**
|
||||
|
||||
Run: `Rscript -e 'invisible(parse("local/build-one.R")); invisible(parse("local/build-all.R")); cat("parse ok\n")'`
|
||||
Expected: `parse ok`.
|
||||
|
||||
- [ ] **Step 4: Commit**
|
||||
|
||||
```bash
|
||||
git add local/build-one.R local/build-all.R
|
||||
git commit -m "feat(patches): pass patch registry to bincraft build calls"
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
Loading…
Reference in a new issue