devxy/build-cran-binaries
Watch
1
0
Fork
You've already forked build-cran-binaries
 0
Code Issues 12 Pull requests Releases Activity

fix(ci): give each xvfb-run its own display (#230)
All checks were successful
ci/crow/cron/process-updates/2 Pipeline was successful
Details
ci/crow/cron/process-updates/11 Pipeline was successful
Details
ci/crow/cron/process-updates/8 Pipeline was successful
Details
ci/crow/cron/process-updates/9 Pipeline was successful
Details
ci/crow/cron/process-updates/16 Pipeline was successful
Details
ci/crow/cron/process-updates/13 Pipeline was successful
Details
ci/crow/cron/process-updates/15 Pipeline was successful
Details
ci/crow/cron/process-updates/10 Pipeline was successful
Details
ci/crow/cron/process-updates/12 Pipeline was successful
Details
ci/crow/cron/process-updates/14 Pipeline was successful
Details
ci/crow/cron/process-updates/4 Pipeline was successful
Details
ci/crow/cron/process-updates/3 Pipeline was successful
Details
ci/crow/cron/process-updates/5 Pipeline was successful
Details
ci/crow/cron/process-updates/7 Pipeline was successful
Details
ci/crow/cron/process-updates/1 Pipeline was successful
Details
ci/crow/cron/process-updates/6 Pipeline was successful
Details

Browse source 
Every `process-cran-updates-ubuntu-2204-arm64` cron run since pipeline 13744 has failed with `xvfb-run: error: Xvfb failed to start` (e.g. 13829).

## Cause

The newer-R loop added in #216 runs two `xvfb-run` calls back to back: the R-minor-sensitive `process_cran_updates` pass, then `local/build-newer-r.R`.
Without `-a`, `xvfb-run` always uses display `:99`, and on exit it kills its Xvfb without waiting for it.
The second call can therefore start while the old server still holds the `:99` lock, so the new Xvfb refuses to start.
Only ubuntu-2204-arm64 hits this because it is the only image with a second R minor installed, so the loop body only runs there.

## Change

- Default `XVFB_ARGS` to `-a` (`--auto-servernum`) in `process-updates.yaml`, `build-all-versions.yaml` and `weekly-rebuild-missing.yaml`, so each call picks a free display.
- The RHEL 10 `xwfb-run` branch still overrides `XVFB_ARGS` with `-c weston`, so it is unchanged.

## Verification

`crow lint .crow/` passes.
A local repro was not possible (`docker run` hangs on the dev host), so the next ubuntu-2204-arm64 cron run is the real check.

Reviewed-on: #230
This commit is contained in:
Patrick Schratz 2026-10-11 12:12:28 +00:00 • committed by Patrick Schratz
commit d992a2b636
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.crow/build-all-versions.yaml
View file

@ -153,7 +153,7 @@ steps:
# not visible here. Install the packages needed to recompute the snapshot
# and query build metadata in every build job.
- UVR_R_BIN=/opt/R/$R_VERSION/bin/R local/uvr-install.sh RPostgres s3fs data.table future jsonlite
- XVFB=$(command -v xwfb-run 2>/dev/null || command -v xvfb-run); XVFB_ARGS=""; if command -v xwfb-run >/dev/null 2>&1; then dnf install -y -q weston 2>/dev/null; XVFB_ARGS="-c weston"; fi
- XVFB=$(command -v xwfb-run 2>/dev/null || command -v xvfb-run); XVFB_ARGS="-a"; if command -v xwfb-run >/dev/null 2>&1; then dnf install -y -q weston 2>/dev/null; XVFB_ARGS="-c weston"; fi
- $XVFB $XVFB_ARGS -n $SPLIT_INDEX -- /opt/R/$R_VERSION/bin/Rscript local/build-all.R $SPLIT_INTO $SPLIT_INDEX $NCPUS 2>&1
- |
PRIMARY_MINOR=$(echo "$R_VERSION" | cut -d. -f1-2)