devxy/build-cran-binaries
Watch
1
0
Fork
You've already forked build-cran-binaries
 0
Code Issues 10 Pull requests Releases Activity

refactor(ci): simplify process-updates cache cleanup (#76)
All checks were successful
ci/crow/cron/process-updates-alpine-323-arm64 Pipeline was successful
Details
ci/crow/cron/process-updates-redhat-9-arm64 Pipeline was successful
Details
ci/crow/cron/process-updates-ubuntu-2204-amd64 Pipeline was successful
Details
ci/crow/cron/process-updates-ubuntu-2204-arm64 Pipeline was successful
Details
ci/crow/cron/process-updates-ubuntu-2404-amd64 Pipeline was successful
Details
ci/crow/cron/process-updates-ubuntu-2404-arm64 Pipeline was successful
Details
ci/crow/cron/process-updates-redhat-10-amd64 Pipeline was successful
Details
ci/crow/cron/process-updates-redhat-10-arm64 Pipeline was successful
Details
ci/crow/cron/process-updates-alpine-322-amd64 Pipeline was successful
Details
ci/crow/cron/process-updates-alpine-322-arm64 Pipeline was successful
Details
ci/crow/cron/weekly-audit-missing-alpine-322-amd64 Pipeline was successful
Details
ci/crow/cron/weekly-audit-missing-alpine-322-arm64 Pipeline was successful
Details
ci/crow/cron/process-updates-redhat-9-amd64 Pipeline was successful
Details
ci/crow/cron/process-updates-alpine-323-amd64 Pipeline was successful
Details
ci/crow/cron/process-updates-redhat-8-arm64 Pipeline was successful
Details
ci/crow/cron/process-updates-redhat-8-amd64 Pipeline was successful
Details

Browse source 
## Summary

The `rm -rf /mnt/cache/...` block in 14 `process-updates-*` files had two real issues:

1. `/mnt/cache/pkgcache/R/pkgcache` listed twice — harmless duplicate.
2. `/mnt/cache/R-pkgs/00LOCK-pak/mnt/cache/R-pkgs/00LOCK-RPostgres` — missing a space between two paths, so `rm` walks a nested nonsense path that never exists. The `00LOCK-RPostgres` lock cleanup never actually ran.

Collapses to the same shape `weekly-rebuild-missing-*` already uses:

```
rm -rf /mnt/cache/R-pkgs/00LOCK-* /mnt/cache/R-pkgs/{bincraft,pkgcache} /mnt/cache/pkgcache/R/pkgcache
```

`00LOCK-*` covers every stale lock (pak, bincraft, RPostgres, r-pkg-binaries, …) without enumerating them, so adding a new locked package later doesn't need another YAML touch.

14 files, 1 line changed each.

Reviewed-on: #76
This commit is contained in:
Patrick Schratz 2026-06-12 13:41:53 +00:00 • committed by Patrick Schratz
commit 4242e63f30
1 changed files with 14 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.crow/process-updates-redhat-10-amd64.yaml
View file

@ -52,7 +52,7 @@ steps:
# - amd64-binaries-r-dep-cache-redhat-10:/mnt/cache
commands:
- git clone -q https://pat-s:$$REPO_RO_TOKEN@git.devxy.io/devxy/build-cran-binaries.git .
- rm -rf /mnt/cache/R-pkgs/00LOCK-r-pkg-binaries /mnt/cache/R-pkgs/00LOCK-bincraft /mnt/cache/R-pkgs/00LOCK-pak /mnt/cache/pkgcache/R/pkgcache /mnt/cache/pkgcache/R/pkgcache /mnt/cache/R-pkgs/pkgcache /mnt/cache/R-pkgs/00LOCK-pak/mnt/cache/R-pkgs/00LOCK-RPostgres /mnt/cache/R-pkgs/bincraft
- rm -rf /mnt/cache/R-pkgs/00LOCK-* /mnt/cache/R-pkgs/bincraft /mnt/cache/R-pkgs/pkgcache /mnt/cache/pkgcache/R/pkgcache
- /opt/R/$R_VERSION/bin/R -q -e 'if (!requireNamespace("bincraft", quietly = TRUE) || packageVersion("bincraft") != "4.1.1") pak::pak("git::https://codefloe.com/rpkgs/bincraft.git@v4.1.1")'
- /opt/R/$R_VERSION/bin/R -q -e 'packageVersion("bincraft")'
- mkdir -p /mnt/cache/pkgcache /mnt/cache/R-pkgs /mnt/cache/ccache /mnt/cache/packages