From 32719ff95716003f421d6c0ad6c4e80b7489b711 Mon Sep 17 00:00:00 2001
From: pat-s <patrick.schratz@gmail.com>
Date: Mon, 29 Jul 2024 16:31:51 +0200
Subject: [PATCH] be more precise with upload success message

---
 .woodpecker/build.yaml | 2 +-
 R/build_binaries.R     | 1 -
 R/upload.R             | 2 ++
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.woodpecker/build.yaml b/.woodpecker/build.yaml
index 657795f..dcb9c55 100644
--- a/.woodpecker/build.yaml
+++ b/.woodpecker/build.yaml
@@ -6,7 +6,7 @@ skip_clone: true
 matrix:
   include:
     - PLATFORM: rhel-9
-      BLOCK: 903:1450
+      BLOCK: 920:1450
     # - PLATFORM: rhel-9
     #   BLOCK: 1051:1450
     # - PLATFORM: rhel-9
diff --git a/R/build_binaries.R b/R/build_binaries.R
index 154f6cd..83d0605 100644
--- a/R/build_binaries.R
+++ b/R/build_binaries.R
@@ -123,7 +123,6 @@ build_binary_package <- function(package_name, tag = NULL, codename = NULL,
         {
           p()
           dump <- upload_single_binary_to_s3(package_name = x, tag = y, force = force, build_for_minor = build_for_minor, debug = debug)
-          cli::cli_alert_success("Successfully uploaded package {.pkg {x}} with tag {.field {y}}.")
         },
         error = function(e) {
           message(sprintf("Error in uploading package %s with tag %s: %s", x, y, e))
diff --git a/R/upload.R b/R/upload.R
index d4d6549..825bfb3 100644
--- a/R/upload.R
+++ b/R/upload.R
@@ -46,6 +46,7 @@ upload_single_binary_to_s3 <- function(
       sprintf("%s/%s", local_bin_path, tarball_name),
       sprintf("%s/%s", remote_bin_path, tarball_name)
     )
+    cli::cli_alert_success("Successfully uploaded package {.pkg {x}} with tag {.field {y}}.")
     cli::cli_alert("{.fun upload_single_binary_to_s3}: Deleting binary for {.pkg {package_name}} {.field {tag}} at path {.path {sprintf('%s/%s', local_bin_path, tarball_name)}}.")
     file.remove(sprintf("%s/%s", local_bin_path, tarball_name))
   } else if (exists && force) {
@@ -55,6 +56,7 @@ upload_single_binary_to_s3 <- function(
       sprintf("%s/%s", remote_bin_path, tarball_name),
       overwrite = TRUE
     )
+    cli::cli_alert_success("Successfully uploaded package {.pkg {x}} with tag {.field {y}}.")
     cli::cli_alert("{.fun upload_single_binary_to_s3}: Deleting binary for {.pkg {package_name}} {.field {tag}} at path {.path {sprintf('%s/%s', local_bin_path, tarball_name)}}.")
     file.remove(sprintf("%s/%s", local_bin_path, tarball_name))
   } else if (exists && !force) {